Sort added equal items ranges randomization #34393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-not-for-changelog
alexey-milovidov
approved these changes
Feb 7, 2022
robot-clickhouse
added
pr-build
danlark1
reviewed
Feb 7, 2022
danlark1
reviewed
Feb 8, 2022
kitaisreal
force-pushed
the
sort-added-equal-items-randomization
branch
2 times, most recently
from
500fae2 to
2e4c79b
Compare
danlark1
reviewed
Feb 8, 2022
kitaisreal
force-pushed
the
sort-added-equal-items-randomization
branch
from
9dbb5a1 to
7b828b4
Compare
kitaisreal
commented
Feb 11, 2022
| @@ -17,7 +17,7 @@ ${CLICKHOUSE_CLIENT} --query "select count() > 1 as ok from (select * from odbc( | |||
| ${CLICKHOUSE_CLIENT} --query "CREATE TABLE t (x UInt8, y Float32, z String) ENGINE = Memory" | |||
| ${CLICKHOUSE_CLIENT} --query "INSERT INTO t VALUES (1,0.1,'a я'),(2,0.2,'b ą'),(3,0.3,'c d')" | |||
|
|
|||
| ${CLICKHOUSE_CLIENT} --query "SELECT * FROM odbc('DSN={ClickHouse DSN (ANSI)}','$CLICKHOUSE_DATABASE','t') ORDER BY x" | |||
| ${CLICKHOUSE_CLIENT} --query "SELECT * FROM odbc('DSN={ClickHouse DSN (Unicode)}','$CLICKHOUSE_DATABASE','t') ORDER BY x" | |||
| ${CLICKHOUSE_CLIENT} --query "SELECT x, y, z FROM odbc('DSN={ClickHouse DSN (ANSI)}','$CLICKHOUSE_DATABASE','t') ORDER BY x" | |||
There was a problem hiding this comment.
It seems that columns order for some reason is not specified if we SELECT * FROM odbc.
https://s3.amazonaws.com/clickhouse-test-reports/34393/e8fe6ed13b15ff88de45704615db2a7e96f95943/stateless_tests__debug__actions__[1/3].html
CC: @alexey-milovidov
kitaisreal
force-pushed
the
sort-added-equal-items-randomization
branch
from
9a8e4bf to
e13a0bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog Entry:
Ensure that tests don't depend on the result of non-stable sorting of equal elements. Added equal items ranges randomization in debug after sort to prevent issues when we rely on equal items sort order.