Workaround for bug when AWS mistakenly set Content-Type to XML #34433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
kitaisreal
approved these changes
Feb 9, 2022
|
Need to fix flaky test 02207_s3_content_type. |
alesapin
approved these changes
Feb 15, 2022
|
Waiting only for flaky check. |
|
Finally! |
| @@ -10,15 +10,4 @@ $CLICKHOUSE_CLIENT --query " | |||
| INSERT INTO TABLE FUNCTION s3('http://localhost:11111/test/content-type.csv.gz', 'test', 'testtest', 'CSV', 'number UInt64') SELECT number FROM numbers(1000000) SETTINGS s3_max_single_part_upload_size = 10000, s3_truncate_on_insert = 1; | |||
| " | |||
|
|
|||
| # strace -e trace=network,write -s1000 -f ~/work/ClickHouse/mc cat clickminio/test/content-type.csv.gz >/dev/null | |||
There was a problem hiding this comment.
What was wrong with this command, just curious?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
When large files were written with
s3table function or table engine, the content type on the files was mistakenly set toapplication/xmldue to a bug in the AWS SDK. This closes #33964.