Fix typo of update_lag #35089
Merged
Fix typo of update_lag #35089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In external dictionary providers, the allowed keys for configuration seemed to have a typo of "update_lag" as "update_tag", preventing the use of "update_lag". This change fixes that.
robot-clickhouse
added
the
pr-bugfix
|
|
|
Maybe we should keep existing name as well to be backward compatible |
kitaisreal
added
the
pr-must-backport
|
@vdimir it is not about setting name. Previously we added check that only allow some specific tags to be presented in dictionary configuration. |
kitaisreal
approved these changes
Mar 7, 2022
This was referenced Mar 8, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Mar 8, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Mar 8, 2022
kitaisreal
added a commit
that referenced
this pull request
Mar 8, 2022
Backport #35089 to 22.1: Fix typo of update_lag
kitaisreal
added a commit
that referenced
this pull request
Mar 8, 2022
Backport #35089 to 22.2: Fix typo of update_lag
Felixoid
added
the
pr-backports-created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In external dictionary providers, the allowed keys for configuration seemed to have a typo
of "update_lag" as "update_tag", preventing the use of "update_lag". This change fixes that.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed the "update_lag" external dictionary configuration option being unusable with the error message
Unexpected key `update_lag` in dictionary source configuration