Readme example fix #139
Merged
Readme example fix #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, when trying to run the README example we get the
following error:
% go run ./main.go
# command-line-arguments
./main.go:13:43: too many arguments in call to ch.Dial
have (context.Context, string, ch.Options)
want (context.Context, ch.Options)
See also 9cc1b6e ("refactor: make address optional")
which removed the address field of Dial.
Signed-off-by: Alexandre Perrin <[email protected]>
Move Result before OnResult since the latter is optional and called after the former. Signed-off-by: Alexandre Perrin <[email protected]>
|
|
ernado
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of fix for the README example, see commits.