Skip to content

Commit

Permalink
Fix validation errors in Superset connection dialog (#46)
Browse files Browse the repository at this point in the history
  • Loading branch information
genzgd authored Sep 25, 2022
1 parent 7ef1a53 commit ed6a863
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion clickhouse_connect/VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.2.8
0.2.9
4 changes: 3 additions & 1 deletion clickhouse_connect/cc_superset/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,9 @@ def validate_parameters(cls, parameters: BasicParametersType) -> List[SupersetEr
ErrorLevel.ERROR,
{'invalid': ['host']},
)]
port = parameters.get('port', default_port('http', parameters.get('encryption', False)))
port = parameters.get('port')
if port is None:
port = default_port('http', parameters.get('encryption', False))
try:
port = int(port)
except (ValueError, TypeError):
Expand Down

0 comments on commit ed6a863

Please sign in to comment.