Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid params fix #55

Merged
merged 2 commits into from
Oct 15, 2022
Merged

Valid params fix #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8712dc2
Fix various superset issues
genzgd Oct 15, 2022
d5050ca
Fix lint
genzgd Oct 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
## ClickHouse Connect ChangeLog

### Deprecation warning
### Release 0.3.0 2022-10-15

* In the next minor release (0.3.0) the row_binary option for ClickHouse serialization will be removed. The performance is significantly lower than Native format and maintaining the option adds complexity with no corresponding benefit
#### Row Binary Removed
The row_binary option for ClickHouse serialization has been removed. The performance is significantly lower than Native format and maintaining the option added complexity with no corresponding benefit

#### Bug Fixes
* The Database Connection dialog was broken in the latest Superset development builds. This has been fixed
* IPv6 Addresses fixed for default Superset configuration

### Release 0.2.10 2022-09-28

Expand Down
2 changes: 1 addition & 1 deletion clickhouse_connect/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.2.10
0.3.0
1 change: 1 addition & 0 deletions clickhouse_connect/cc_superset/datatypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ def configure_types():
"""
set_default_formats(FixedString='string',
IPv4='string',
IPv6='string',
UInt64='signed',
UUID='string')
compiled = [(re.compile(pattern, re.IGNORECASE), gen_type) for pattern, gen_type in type_mapping]
Expand Down
6 changes: 5 additions & 1 deletion clickhouse_connect/cc_superset/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,11 @@ def get_parameters_from_uri(cls, uri: str, *_args, **_kwargs) -> BasicParameters
encryption=encryption)

@classmethod
def validate_parameters(cls, parameters: BasicParametersType) -> List[SupersetError]:
# pylint: disable=arguments-renamed
def validate_parameters(cls, properties) -> List[SupersetError]:
# The newest versions of superset send a "properties" object with a parameters key, instead of just
# the parameters, so we hack to be compatible
parameters = properties.get('parameters', properties)
host = parameters.get('host', None)
if not host:
return [SupersetError(
Expand Down