-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tissue type when creating scout config file #502
Conversation
I'm sure it's because I don't have much experience with it, but it's 2 days that I'm literally getting crazy over linting problems: the more I fix them, the more pop up at the next build. Tried reformatting the file with black but I still get new errors every build. Any help would be very appreciated. I'm going to leave this PR for when I will have more time otherwise. |
See last comment on this issue: pylint-dev/pylint#2944, the indentation message might be caused by
This method/function doesn't touch the class at all so maybe use @staticmethod? |
Very likely, the error showed immediately after I reformatted with black, I'll try to revert to a version before. Thanks! |
Thanks @hassanfa, the 4 spaces messages are gone now! |
YESSS IT PASSED!!! |
@northwestwitch worthy of adding to resume 🤣 |
Indeed! :D |
This is ready for review, anybody? |
Thanks @patrikgrenfeldt, I'll fix them asap! |
I worked on this PR a month ago and many things have changed since then, I'll try to fix it here but it might take longer than I prevented..! |
Closing this and opening a new PR with the same code from the updated master. Otherwise it was conflict hell! |
This PR should add a field
tissue_type
for each individual when creating a scout config file.fix #497
How to prepare for test:
bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-cg-stage.sh pass_tissue_type
us
How to test:
cg upload scout bosscod
Expected test outcome:
Review:
Thanks for filling in who performed the code review and the test!
This is a minor version update because it adds a new functionality.