[crmsh-4.6] Fix: bootstrap: ssh key of the init node is duplicated in the authorized_keys files of other node (bsc#1218940) #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
authorized_keys files of other node (bsc#1218940) When a cluster is bootstrap with 'crm cluster init -N', the public key of the init node is added for mutiple times to the authorized_key files of other nodes. Fix by reusing `AuthorizedKeyManager.add` in swap_public_ssh_key.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## crmsh-4.6 #1311 +/- ##
==========================================
Coverage 52.66% 52.67%
==========================================
Files 79 79
Lines 23938 23937 -1
==========================================
+ Hits 12607 12608 +1
+ Misses 11331 11329 -2 ☔ View full report in Codecov by Sentry. |
liangxin1300
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a cluster is bootstrap with 'crm cluster init -N', the public key of the init node is added for mutiple times to the authorized_key files of other nodes.
Fix by reusing
AuthorizedKeyManager.addin swap_public_ssh_key.