Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Dev: ui_configure: Deprecate configure erase sub-command" (bsc#1228713) #1501

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

liangxin1300
Copy link
Collaborator

Revert #1107, since configure erase is still used by the user, it shouldn't be deprecated

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.56%. Comparing base (6803994) to head (40d8b2b).
Report is 12 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 54.26% <ø> (+<0.01%) ⬆️
unit 52.47% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
crmsh/ui_configure.py 44.43% <ø> (+0.15%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

liangxin1300 added a commit that referenced this pull request Aug 22, 2024
@liangxin1300 liangxin1300 merged commit 9ee6ca4 into ClusterLabs:master Aug 22, 2024
31 checks passed
liangxin1300 added a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants