Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev: ra: Drop legacy code to get metadata of the pacemaker daemons #1647

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Dev: ra: Drop legacy code to get metadata of the pacemaker daemons #1647

merged 1 commit into from
Dec 30, 2024

Conversation

liangxin1300
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.72%. Comparing base (aae750f) to head (9bdac41).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
crmsh/ra.py 0.00% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 53.55% <50.00%> (+<0.01%) ⬆️
unit 53.08% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/cibconfig.py 64.63% <100.00%> (ø)
crmsh/ra.py 52.80% <0.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review December 30, 2024 10:59
@liangxin1300 liangxin1300 requested a review from zzhou1 December 30, 2024 10:59
zzhou1
zzhou1 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@zzhou1 zzhou1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liangxin1300 liangxin1300 merged commit 14da522 into ClusterLabs:master Dec 30, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzhou1 zzhou1 zzhou1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liangxin1300 @zzhou1