[Improve crm report] Better performance #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangxin1300
force-pushed
the
20211020_report_performance
branch
4 times, most recently
from
9cdee81 to
f07c71b
Compare
zzhou1
reviewed
Oct 25, 2021
hb_report/utillib.py
Outdated
| for p in process_list: | ||
| p.join() | ||
| collect_func_list = generate_collect_functions() | ||
| pool = multiprocessing.Pool(processes=len(collect_func_list)) |
There was a problem hiding this comment.
I suggest the following instead,
processes=round(0.8*multiprocessing.cpu_count())
First of all, too many processes larger than the actual cpu_count() creates unnecessary cpu context switches.
Secondly, its makes sense to me to limit crm report a little in a conservative way. Don't let is occupy all CPUs.
There was a problem hiding this comment.
OK,
BTW, That remind me to "combine" some "collect_" functions which have similar logic into one, then it can also reduce the number of process
liangxin1300
force-pushed
the
20211020_report_performance
branch
from
f07c71b to
7ba7467
Compare
zzhou1
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More faster
By using multiprocessing.Process correctly and make all collect related functions running in parallel:
In current code, report process is not in parallel:
This PR, report process is in parallel:
Note: the linear behavior for the time when nodes increasing in this PR, is because the
analyzeandsanitizefunction in master should process more dataChanges