Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: xml: Fix segfault in TRACKING_CHANGES() #448

Merged
merged 1 commit into from
Feb 28, 2014

Conversation

gao-yan
Copy link
Member

@gao-yan gao-yan commented Feb 28, 2014

No description provided.

@beekhof
Copy link
Member

beekhof commented Feb 28, 2014

Curious to know where/how you hit this...

@gao-yan
Copy link
Member Author

gao-yan commented Feb 28, 2014

An user reported that. When he was using mgmtd, which was doing lrmd_handshake():

#0 0x00007f4a4f315ab3 in crm_xml_add (node=node@entry=0x230c930, name=name@entry=0x7f4a4ffe1cf8 "t", value=value@entry=0x7f4a4ffe214e "lrmd") at xml.c:1760
1760 if(TRACKING_CHANGES(node)) {
(gdb) bt
#0 0x00007f4a4f315ab3 in crm_xml_add (node=node@entry=0x230c930, name=name@entry=0x7f4a4ffe1cf8 "t", value=value@entry=0x7f4a4ffe214e "lrmd") at xml.c:1760

No idea if it happens in other cases.

@gao-yan
Copy link
Member Author

gao-yan commented Feb 28, 2014

#1 0x00007f4a4ffe08fe in lrmd_handshake (lrmd=0x230b590, name=0x7f4a51280e59 "mgmtd") at lrmd_client.c:876

beekhof added a commit that referenced this pull request Feb 28, 2014
Fix: xml: Fix segfault in TRACKING_CHANGES()
@beekhof beekhof merged commit 28fba1c into ClusterLabs:master Feb 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants