ruff: enable ruff linter I (isort) and re-format with ruff isort

* https://docs.astral.sh/ruff/rules/#isort-i
* deviations from isort:
  * astral-sh/ruff#1381
  * astral-sh/ruff#2104

pcs/cluster.py

@@ -68,9 +68,8 @@
 from pcs.lib import sbd as lib_sbd
 from pcs.lib.commands.remote_node import _destroy_pcmk_remote_env
 from pcs.lib.communication.nodes import CheckAuth
-from pcs.lib.communication.tools import RunRemotelyBase
+from pcs.lib.communication.tools import RunRemotelyBase, run_and_raise
 from pcs.lib.communication.tools import run as run_com_cmd
-from pcs.lib.communication.tools import run_and_raise
 from pcs.lib.corosync import qdevice_net
 from pcs.lib.corosync.live import (
     QuorumStatusException,

pcs/daemon/app/common.py

@@ -8,9 +8,9 @@
 from tornado.web import (
     Finish,
     HTTPError,
+    RequestHandler,
 )
 from tornado.web import RedirectHandler as TornadoRedirectHandler
-from tornado.web import RequestHandler
 
 RoutesType = Iterable[
     tuple[str, Type[RequestHandler], Optional[dict[str, Any]]]

pcs/daemon/run.py

@@ -31,13 +31,11 @@
     api_v1,
     api_v2,
     auth,
-)
-from pcs.daemon.app import capabilities as capabilities_app
-from pcs.daemon.app import (
     sinatra_remote,
     sinatra_ui,
     ui,
 )
+from pcs.daemon.app import capabilities as capabilities_app
 from pcs.daemon.app.common import (
     Http404Handler,
     RedirectHandler,

pcs/lib/cib/fencing_topology.py

@@ -32,9 +32,9 @@
     ReportItemList,
     ReportItemSeverity,
     ReportProcessor,
+    has_errors,
 )
 from pcs.common.reports import codes as report_codes
-from pcs.common.reports import has_errors
 from pcs.common.reports.item import ReportItem
 from pcs.common.types import StringSequence
 from pcs.common.validate import is_integer

pcs/lib/commands/cluster.py

@@ -69,16 +69,15 @@
     EnableSbdService,
     SetSbdConfig,
 )
-from pcs.lib.communication.tools import AllSameDataMixin
+from pcs.lib.communication.tools import AllSameDataMixin, run_and_raise
 from pcs.lib.communication.tools import run as run_com
-from pcs.lib.communication.tools import run_and_raise
 from pcs.lib.corosync import (
     config_facade,
     config_parser,
     config_validators,
+    qdevice_net,
 )
 from pcs.lib.corosync import constants as corosync_constants
-from pcs.lib.corosync import qdevice_net
 from pcs.lib.env import (
     LibraryEnvironment,
     WaitType,

pcs/lib/commands/cluster_property.py

@@ -24,9 +24,9 @@
     ResourceAgentError,
     ResourceAgentFacade,
     ResourceAgentMetadata,
+    resource_agent_error_to_report_item,
 )
 from pcs.lib.resource_agent import const as ra_const
-from pcs.lib.resource_agent import resource_agent_error_to_report_item
 from pcs.lib.resource_agent.facade import ResourceAgentFacadeFactory
 
 

pcs/lib/file/raw_file.py

@@ -13,12 +13,12 @@
 # places
 # pylint: disable=unused-import
 from pcs.common import reports
-from pcs.common.file import FileMetadata
-from pcs.common.file import RawFile as RealFile
 from pcs.common.file import (
+    FileMetadata,
     RawFileError,
     RawFileInterface,
 )
+from pcs.common.file import RawFile as RealFile
 
 # TODO add logging (logger / debug reports ?)
 

pcs/utils.py

@@ -44,12 +44,10 @@
     timeout_to_seconds_legacy,
 )
 from pcs.cli.file import metadata as cli_file_metadata
-from pcs.cli.reports import ReportProcessorToConsole
+from pcs.cli.reports import ReportProcessorToConsole, process_library_reports
 from pcs.cli.reports import output as reports_output
-from pcs.cli.reports import process_library_reports
-from pcs.common import const
+from pcs.common import const, file_type_codes
 from pcs.common import file as pcs_file
-from pcs.common import file_type_codes
 from pcs.common import pacemaker as common_pacemaker
 from pcs.common import pcs_pycurl as pycurl
 from pcs.common.host import PcsKnownHost

pcs_test/tier1/legacy/test_alert.py

@@ -1,13 +1,13 @@
 import unittest
 
 from pcs_test.tools.assertions import AssertPcsMixin
-from pcs_test.tools.misc import ParametrizedTestMetaClass
-from pcs_test.tools.misc import get_test_resource as rc
 from pcs_test.tools.misc import (
+    ParametrizedTestMetaClass,
     get_tmp_file,
     outdent,
     write_file_to_tmpfile,
 )
+from pcs_test.tools.misc import get_test_resource as rc
 from pcs_test.tools.pcs_runner import PcsRunner
 
 empty_cib = rc("cib-empty.xml")

pcs_test/tier1/legacy/test_cluster.py

@@ -4,16 +4,16 @@
 from unittest import TestCase
 
 from pcs_test.tools.assertions import AssertPcsMixin
-from pcs_test.tools.misc import compare_version
-from pcs_test.tools.misc import get_test_resource as rc
 from pcs_test.tools.misc import (
+    compare_version,
     get_tmp_dir,
     get_tmp_file,
     outdent,
     read_test_resource,
     skip_unless_root,
     write_file_to_tmpfile,
 )
+from pcs_test.tools.misc import get_test_resource as rc
 from pcs_test.tools.pcs_runner import (
     PcsRunner,
     pcs,

pcs_test/tier1/legacy/test_constraints.py

@@ -25,14 +25,14 @@
     wrap_element_by_master,
     wrap_element_by_master_file,
 )
-from pcs_test.tools.misc import ParametrizedTestMetaClass
-from pcs_test.tools.misc import get_test_resource as rc
 from pcs_test.tools.misc import (
+    ParametrizedTestMetaClass,
     get_tmp_file,
     outdent,
     skip_unless_crm_rule,
     write_file_to_tmpfile,
 )
+from pcs_test.tools.misc import get_test_resource as rc
 from pcs_test.tools.pcs_runner import (
     PcsRunner,
     pcs,

pcs_test/tier1/legacy/test_stonith.py

@@ -10,16 +10,16 @@
 from pcs_test.tools.assertions import AssertPcsMixin
 from pcs_test.tools.bin_mock import get_mock_settings
 from pcs_test.tools.fixture_cib import CachedCibFixture
-from pcs_test.tools.misc import ParametrizedTestMetaClass
-from pcs_test.tools.misc import get_test_resource as rc
 from pcs_test.tools.misc import (
+    ParametrizedTestMetaClass,
     get_tmp_file,
     is_minimum_pacemaker_version,
     outdent,
     skip_unless_crm_rule,
     write_data_to_tmpfile,
     write_file_to_tmpfile,
 )
+from pcs_test.tools.misc import get_test_resource as rc
 from pcs_test.tools.pcs_runner import PcsRunner
 
 PCMK_2_0_3_PLUS = is_minimum_pacemaker_version(2, 0, 3)

pcs_test/tier1/test_cluster_pcmk_remote.py

@@ -2,9 +2,8 @@
 
 from pcs_test.tier1.cib_resource.common import ResourceTest
 from pcs_test.tools.bin_mock import get_mock_settings
-from pcs_test.tools.misc import ParametrizedTestMetaClass
+from pcs_test.tools.misc import ParametrizedTestMetaClass, write_data_to_tmpfile
 from pcs_test.tools.misc import get_test_resource as rc
-from pcs_test.tools.misc import write_data_to_tmpfile
 
 ERRORS_HAVE_OCCURRED = (
     "Error: Errors have occurred, therefore pcs is unable to continue\n"

pcs_test/tier1/test_quorum.py

@@ -2,12 +2,12 @@
 from unittest import TestCase
 
 from pcs_test.tools.assertions import AssertPcsMixin
-from pcs_test.tools.misc import ParametrizedTestMetaClass
-from pcs_test.tools.misc import get_test_resource as rc
 from pcs_test.tools.misc import (
+    ParametrizedTestMetaClass,
     get_tmp_file,
     write_file_to_tmpfile,
 )
+from pcs_test.tools.misc import get_test_resource as rc
 from pcs_test.tools.pcs_runner import PcsRunner
 
 coro_conf = rc("corosync.conf")

pyproject.toml

@@ -80,6 +80,7 @@ target-version = "py39"
 # ruff rules docs: https://docs.astral.sh/ruff/rules/
 # pylint rules in ruff: # https://github.com/astral-sh/ruff/issues/970
 select = [
+  "I",
   "PL", # pylint convention, error, refactoring, warning
 ]
 # ruff does not respect pylint ignore directives