Skip to content

Revert to .NET Framework #956

Revert to .NET Framework

Revert to .NET Framework #956

Triggered via pull request February 21, 2024 10:42
Status Success
Total duration 4m 51s
Artifacts 3

build.yml

on: pull_request
Matrix: build-clients
Fit to window
Zoom out
Zoom in

Annotations

30 warnings
build-clients (Ares): ClientCore/Enums/AllowPrivateMessagesFromEnum.cs#L3
Rename type name AllowPrivateMessagesFromEnum so that it does not end in 'Enum' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build-clients (Ares): ClientCore/OSVersion.cs#L1
Declare types in namespaces (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1050)
build-clients (Ares): ClientCore/CnCNet5/GameCollection.cs#L15
Rename type name GameCollection so that it does not end in 'Collection' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build-clients (Ares): ClientCore/SavedGameManager.cs#L15
Member 'saveRenameInProgress' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
build-clients (Ares): ClientCore/CnCNet5/NameValidator.cs#L24
Prefer 'AsSpan' over 'Substring' when span-based overloads are available (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1846)
build-clients (Ares): ClientCore/ClientConfiguration.cs#L239
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'ClientConfiguration.GetThemeInfoFromIndex(int)' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
build-clients (Ares): ClientCore/ClientConfiguration.cs#L289
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
build-clients (Ares): ClientCore/ClientConfiguration.cs#L295
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
build-clients (Ares): ClientCore/CnCNet5/GameCollection.cs#L280
Use 'string.StartsWith(char)' instead of 'string.StartsWith(string)' when you have a string with a single char (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1866)
build-clients (Ares): ClientCore/CnCNet5/GameCollection.cs#L280
The behavior of 'string.StartsWith(string)' could vary based on the current user's locale settings. Replace this call in 'ClientCore.CnCNet5.GameCollection.GetIRCChannelNameFromIniFile(Rampastring.Tools.IniFile, string, string)' with a call to 'string.StartsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
build-clients (TS): ClientCore/OSVersion.cs#L1
Declare types in namespaces (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1050)
build-clients (TS): ClientCore/Enums/AllowPrivateMessagesFromEnum.cs#L3
Rename type name AllowPrivateMessagesFromEnum so that it does not end in 'Enum' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build-clients (TS): ClientCore/CnCNet5/GameCollection.cs#L15
Rename type name GameCollection so that it does not end in 'Collection' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build-clients (TS): ClientCore/SavedGameManager.cs#L15
Member 'saveRenameInProgress' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
build-clients (TS): ClientCore/CnCNet5/NameValidator.cs#L24
Prefer 'AsSpan' over 'Substring' when span-based overloads are available (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1846)
build-clients (TS): ClientCore/ClientConfiguration.cs#L239
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'ClientConfiguration.GetThemeInfoFromIndex(int)' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
build-clients (TS): ClientCore/CnCNet5/GameCollection.cs#L280
Use 'string.StartsWith(char)' instead of 'string.StartsWith(string)' when you have a string with a single char (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1866)
build-clients (TS): ClientCore/CnCNet5/GameCollection.cs#L280
The behavior of 'string.StartsWith(string)' could vary based on the current user's locale settings. Replace this call in 'ClientCore.CnCNet5.GameCollection.GetIRCChannelNameFromIniFile(Rampastring.Tools.IniFile, string, string)' with a call to 'string.StartsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
build-clients (TS): ClientCore/CnCNet5/GameCollection.cs#L297
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
build-clients (TS): ClientCore/CnCNet5/GameCollection.cs#L313
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
build-clients (YR): ClientCore/OSVersion.cs#L1
Declare types in namespaces (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1050)
build-clients (YR): ClientCore/Enums/AllowPrivateMessagesFromEnum.cs#L3
Rename type name AllowPrivateMessagesFromEnum so that it does not end in 'Enum' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build-clients (YR): ClientCore/CnCNet5/GameCollection.cs#L15
Rename type name GameCollection so that it does not end in 'Collection' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build-clients (YR): ClientCore/SavedGameManager.cs#L15
Member 'saveRenameInProgress' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
build-clients (YR): ClientCore/CnCNet5/NameValidator.cs#L24
Prefer 'AsSpan' over 'Substring' when span-based overloads are available (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1846)
build-clients (YR): ClientCore/I18N/Translation.cs#L91
Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1510)
build-clients (YR): ClientCore/INIProcessing/IniPreprocessor.cs#L34
Member 'ProcessSection' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
build-clients (YR): ClientCore/INIProcessing/IniPreprocessInfoStore.cs#L54
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
build-clients (YR): ClientCore/I18N/Translation.cs#L291
Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1854)
build-clients (YR): ClientCore/INIProcessing/IniPreprocessInfoStore.cs#L121
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'IniPreprocessInfoStore.Write()' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)

Artifacts

Produced during runtime
Name Size
artifacts-Ares Expired
23.7 MB
artifacts-TS Expired
23.7 MB
artifacts-YR Expired
23.7 MB