Make sure StreamWriter is disposed in time #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SadPencil
force-pushed
the
fix-streamwriter-flush
branch
from
39ebbaa to
0103f4b
Compare
|
Nightly build for this pull request:
|
Metadorius
approved these changes
Feb 25, 2024
SadPencil
added a commit
to SadPencil/xna-cncnet-client
that referenced
this pull request
Oct 4, 2024
SadPencil
added a commit
to SadPencil/xna-cncnet-client
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 6426387 changes the use of StreamWriter by using
using var writer = new StreamWriter();, delaying the disposing work that triggers Flush() to the time when the whole function is ended, i.e., when game is already launched. This increase a chance where the spawner fails to read the configuration file written by the client (although rare).This PR uses
using (var writer = new StreamWriter())to replaceusing var writer = new StreamWriter();