Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add boxGuard ACE3 interaction menu for unlocking a box #42

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

freghar
Copy link
Collaborator

@freghar freghar commented Sep 6, 2022

Limited to Fireteam Leaders or higher ranks.

@JamesTheClarke
Copy link

JamesTheClarke commented Sep 9, 2022

I'm in favour of this addition.

However, I think for an initial roll-out to gauge the impact of this new functionality actual element leaders (Platoon Leader, Squad Leader, MAT Leader, NB Pilot etc.) should suffice since it already provides plenty of people with access to overriding the boxGuard. When employed correctly by the Mission Maker the boxGuard shouldn't be an issue in the first place - if it causes problems it's because it was overlooked during mission design/review. I.e. don't leave boxGuard active on crates during an intended base defense and/or resize the base marker size accordingly to the terrain.

Circumventing the boxGuard is a rare niche case and should not become the new norm. Even during low player number events we usually have at least two elements which would provide three long-range radio leaders (Zeus included) able to unlock the box if it's actually needed.

EDIT: I just double-checked the ranks for support element leaders (MAT, MMG, Mortar etc.) and they are Sergeant which is the current FTL rank. We could update those in compositions to Lieutenant and make that the minimum rank to unlock crates. This would give the following roles access to overriding boxGuard:

  • Platoon Leader
  • Platoon Sergeant
  • Squad Leader
  • MAT Leader
  • MMG Leader
  • ENG Leader
  • DMT Leader
  • HAT Leader
  • HMG Leader
  • Mortar Leader
  • Dagger Leader
  • NB Pilot
  • Falcon Pilot
  • Zeus
  • Co-Zeus

Unlike FTLs all these roles have long-range radios and thus are directly plugged into communications with PLT and HQ. So they can ask for permission to override the boxGuard from anywhere in the map and communicate this directly to Platoon Lead.

@JamesTheClarke JamesTheClarke added the Enhancement Changes to existing features not based on mod updates label Sep 9, 2022
@JamesTheClarke JamesTheClarke added this to the v1.2.6 milestone Sep 9, 2022
@freghar
Copy link
Collaborator Author

freghar commented Sep 9, 2022

For the record - we can easily change the allowed rankId, but I didn't want to condition it by "anyone leading a group", because a player can easily leave an existing group via ACE self-interact and become (technically) a leader of their own group, which would be an easy exploit.

@JamesTheClarke
Copy link

JamesTheClarke commented Sep 9, 2022

I got that, hence my previous proposal to use Lieutenant. :)

Fully agree that it should be based on rankId. Makes it also more easily changeable through compositions rather than having to update cnto-additions.

@freghar
Copy link
Collaborator Author

freghar commented Sep 9, 2022

I got that, hence my previous proposal to use Lieutenant. :)

In that case we should be good as far as this PR goes, the current

rankId _player >= 3

means "Lieutenant or higher", per https://community.bistudio.com/wiki/rankId .

So I guess I was wrong in the initial description, I just copy/pasted the rankid from the ACRE2 volume limiting code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Changes to existing features not based on mod updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants