Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Java Maven not uses settings.xml #794

Closed
RuslanSafa opened this issue Nov 26, 2019 · 4 comments
Closed

Java Maven not uses settings.xml #794

RuslanSafa opened this issue Nov 26, 2019 · 4 comments
Assignees
Labels
good first issue ideal for first-time contributors
Milestone

Comments

@RuslanSafa
Copy link

To analyze my project, it is necessary to specify the settings.xml maven, there is no way to do this in the setup, but from the lack of a project it is not going to, there is accordingly no way to use the product.

@mlangkabel
Copy link
Contributor

@RuslanSafa, thank you very much for bringing this up!

It looks like we'd need to extens the project setup for maven projects with an optional path-picker for a settings.xml file.

And if there is a path set here, the maven commads that Sourcetrail executes need to contain the --settings path/to/settings.xml argument.

@mlangkabel mlangkabel added the good first issue ideal for first-time contributors label Nov 26, 2019
@RuslanSafa
Copy link
Author

@mlangkabel Thank you for the product. I will wait for revision, I really want to use the product.

@egraether egraether added this to the 2020.1 milestone Dec 9, 2019
@mlangkabel
Copy link
Contributor

Implemented with merge of pull request #847. This should be part of our next release.

@RuslanSafa
Copy link
Author

Th's, I'll be waiting

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue ideal for first-time contributors
Projects
None yet
Development

No branches or pull requests

3 participants