Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Add option "Close Tabs to the Right" to right-click context menu of tabs #822

Closed
mlangkabel opened this issue Dec 3, 2019 · 11 comments
Closed
Labels
feature good first issue ideal for first-time contributors

Comments

@mlangkabel
Copy link
Contributor

mlangkabel commented Dec 3, 2019

Implementation suggestion:

  • override void contextMenuEvent(QContextMenuEvent* event) in QtTabsBar
  • Instantiate QtContextMenu and add this action to it (see QtGraphicsView for example)
  • when action is triggered emit a signal, e.g. closeTabsToRight(Id tabId).
  • catch that signal in QtTabsView and handle logic there
@mlangkabel mlangkabel added feature good first issue ideal for first-time contributors labels Dec 3, 2019
@KalshuCodes
Copy link

I am interested to work on the project for some time. Can you provide me with details on how can I start with? I am a 2nd-year undergrad.

@egraether
Copy link
Contributor

@kalashshah11 I updated the description above to give some pointers.

@KalshuCodes
Copy link

@egraether Thanks for updating.Would complete it as soon as possible.

@KalshuCodes
Copy link

@egraether I am getting an error of CMake Error at "D:/......." Could NOT find Boost (missing: Boost_INCLUDE_DIR system program_options filesystem date_time) (Required is at least version "1.67")
and am not being able to load the project

@mlangkabel
Copy link
Contributor Author

Please read the Building the Bare Minimum section of our readme and install the required software.

@KalshuCodes
Copy link

After following the ReadME file, still, I am getting the same errors

@mlangkabel
Copy link
Contributor Author

Are you working on Windows? Maybe you need to define a CMake Cache Entry called BOOST_ROOT (hm, maybe the casing was different, but give it a try) pointing to the directory that contains the "boost" folder, e.g., C:\Program Files\boost\boost_1_68_0. If that doesn't help, just google for CMake find boost and see if anything that comes up helps.

@ghost
Copy link

ghost commented Jan 2, 2020

Hey @kalashshah11 are you still working on this feature?
I think i am already close to a solution.

@ghost
Copy link

ghost commented Jan 2, 2020

Hm, i guess im an impatient one...
Just created a pull request (#875) for this one...

@mlangkabel
Copy link
Contributor Author

It has been 22 days since the last activity on this issue, so I think its fine :)

egraether pushed a commit that referenced this issue Jan 4, 2020
…#875)

* first try to implement closeTabs toRight.

* removed .kdev4

* signals and slots mechanisms for closeTabstoRight now done correct.

* feature: add option to close tabs to the right on right-click context menu.

* indentation, whitespaces etc.
@egraether
Copy link
Contributor

Implemented with 2422e09

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature good first issue ideal for first-time contributors
Projects
None yet
Development

No branches or pull requests

3 participants