Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

FilePath::isValid() broken on Linux/macOS #907

Closed
egraether opened this issue Feb 3, 2020 · 2 comments
Closed

FilePath::isValid() broken on Linux/macOS #907

egraether opened this issue Feb 3, 2020 · 2 comments
Assignees
@mlangkabel
Labels
bug Linux Mac

Comments

@egraether
Copy link
Contributor

egraether commented Feb 3, 2020 •
edited
Loading

Introduced by #901
The method should be tested in FilePathTestSuite
egraether added a commit that referenced this issue Feb 3, 2020
@egraether
src: Hotfix for issue #907
6662a8c
@egraether
Copy link
Contributor Author

egraether commented Feb 3, 2020 •
edited
Loading

@mlangkabel Can you please add tests for FilePath::isValid? I don't quite understand which paths should/shouldn't be valid. Then I can look into fixing this for Linux/macOS.

@mlangkabel mlangkabel self-assigned this Feb 3, 2020
@mlangkabel
Copy link
Contributor

Added pull request #908 for the fix. @egraether: please test on Linux and Mac and modify if necessary before accepting.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mlangkabel mlangkabel

Labels
bug Linux Mac
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@egraether @mlangkabel