Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Rename "aggregration" edge to something better understandable #962

Closed
kobi-ca opened this issue Apr 4, 2020 · 6 comments · Fixed by #1051
Closed

Rename "aggregration" edge to something better understandable #962

kobi-ca opened this issue Apr 4, 2020 · 6 comments · Fixed by #1051
Assignees
Milestone

Comments

@kobi-ca
Copy link

kobi-ca commented Apr 4, 2020

2020.1.117 version.
when a type is using another type(function etc...) it is showing as aggregation instead of using.
I'm sure it was different in prev version. any idea?

thanks,
Kobi

@mlangkabel
Copy link
Contributor

Hm, I cannot reproduce this issue. Can you please post some example code? or a screenshot?

@kobi-ca
Copy link
Author

kobi-ca commented Apr 7, 2020

It might be my misunderstanding.
When it says "aggregation 10 edges"
It does not really mean "type A aggregate type B".
I think it means "type A has 10 connections to type B".
right?
I'm looking at the built in example that comes with the installer.
"ArtificialPlayer" does not really aggregate "Field" right?
There are 24 edges as it says "aggregate 24 edges" and it means there are 24 lines (use, call, type use).

If my understanding above is correct, I suggest renaming "aggregation 24 edges" to something else.
maybe ... "multiple relations 24 edges" or some other better name. what do you think?

@mlangkabel
Copy link
Contributor

Yes, you understood correctly. "The aggregation edge does not mean that types aggregate but that the edge is an aggregation of multiple different edges.

I think you have a valid point and the name of the edge can be missleading. @egraether: what do you think about renaming this edge?

@egraether
Copy link
Contributor

Yes, if renaming makes it more clear, then we should do it (we are not English native speakers after all). Still, we need a new name for this edge type that works as standalone term. Suggestions:

  • bundle edge
  • collection edge

That's all I can think of. I like bundle edge. Any other suggestions?

@egraether egraether added this to the 2020.2-beta milestone Apr 8, 2020
@egraether egraether self-assigned this Apr 8, 2020
@egraether egraether changed the title "using" is showing as "aggregration" Rename "aggregration" edge to something better understandable Apr 8, 2020
@kobi-ca
Copy link
Author

kobi-ca commented Apr 8, 2020

bundle sounds good to me

@egraether
Copy link
Contributor

Final decision: bundled edges

egraether added a commit that referenced this issue Jun 29, 2020
The term aggregation is misleading. Bundled edges is a better definition for this type of edge.

closes #962
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants