-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Xcode 11.4 object version. #746
Conversation
What changed in the project format? Fine merging this but the version wouldn't bump without something changing right? |
Who knows? Apple bumps that number when they do...it seems from the issue report that Xcode 11.4 has a new version of 53. |
I was under the impression it only gets bumped if something actually changes (ex. new attribute gets added) this same topic came up last time #687 (comment) |
Inteeeeresting....you are correct. I guess this doesnt matter since after we added this we are now more strict and crash for an unknown object version. This PR would fix the crash and we should get warnings for new attributes? |
Don't we also crash on unknown attributes? |
No we warn for these. |
It actually says to file an issue in the warning. |
Ah I see Xcodeproj/spec/project/object_spec.rb Lines 160 to 167 in 80a2cda
Would still prefer to actually add support for whatever changed but understand the need to fix crashes sooner rather than later |
closes #744