Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xcode 11.4 object version. #746

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Conversation

dnkoutso
Copy link
Contributor

closes #744

@amorde
Copy link
Member

amorde commented Mar 26, 2020

What changed in the project format? Fine merging this but the version wouldn't bump without something changing right?

@dnkoutso
Copy link
Contributor Author

Who knows? Apple bumps that number when they do...it seems from the issue report that Xcode 11.4 has a new version of 53.

@amorde
Copy link
Member

amorde commented Mar 26, 2020

I was under the impression it only gets bumped if something actually changes (ex. new attribute gets added)

this same topic came up last time #687 (comment)

@dnkoutso
Copy link
Contributor Author

Inteeeeresting....you are correct. I guess this doesnt matter since after we added this we are now more strict and crash for an unknown object version. This PR would fix the crash and we should get warnings for new attributes?

@amorde
Copy link
Member

amorde commented Mar 26, 2020

Don't we also crash on unknown attributes?

@dnkoutso
Copy link
Contributor Author

No we warn for these.

@dnkoutso
Copy link
Contributor Author

It actually says to file an issue in the warning.

@amorde
Copy link
Member

amorde commented Mar 26, 2020

Ah I see

it 'warns if it encounters an unknown attribute in a plist' do
UI.expects(:warn).with "[!] Xcodeproj doesn't know about the following " \
"attributes {\"unknown_attribute\"=>\"might be a reference\"} for the 'PBXFileReference' isa." \
"\nIf this attribute was generated by Xcode please file " \
'an issue: https://github.com/CocoaPods/Xcodeproj/issues/new'
@objects_by_uuid_plist[@object.uuid]['unknown_attribute'] = 'might be a reference'
@object.configure_with_plist(@objects_by_uuid_plist)
end

Would still prefer to actually add support for whatever changed but understand the need to fix crashes sooner rather than later

@dnkoutso dnkoutso merged commit ff4eb39 into CocoaPods:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Xcode 11.4 objectVersion/compatibilityVersion
2 participants