-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade version of python-bitshares to 0.3.x #570
Comments
I agree. I suppose this could be next on the list after the base refactor is done and before actually new features are implemented. Its not the biggest job, but requires mostly testing. |
@joelvai I agree |
I would like to do this before base refactor, as #551 depends on this. |
Is this 570 necessary for #515 ? |
@PermieBTS yes |
my concern about this upgrade to 0.3.x is that currently i'm refactoring base off of pybitshares below 0.2.x If we don't merge and test at least the current portion now, it means base refactor is further behind. Can we just merge in base refactor now and then make unit tests to fit the new framework instead of redundant work? |
So if @joelvai merged this issue 570 and the base refactor, unit tests can then be written using @bitfag docker Therefore skipping out the work to complete redundant unit tests in the old style If @thehapax pushes their work to codaone/542-base-refactor-notests can it be merged friday 10th of May (Tomorrow)? |
I changed the branch - new name is 542-base-refactor-merge, and the pull request is: #579 |
@joelvai you can delete codaone/542-base-refactor-notests this is no longer used. |
Versions upgraded. |
Need to perform version upgrade, as it contains bug fixes and some of our new features will depend on this new version.
The text was updated successfully, but these errors were encountered: