Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle "Unable to find Object" exception #262

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

bitphage
Copy link
Collaborator

@bitphage bitphage commented Aug 6, 2018

No description provided.

@mikakoi
Copy link
Collaborator

mikakoi commented Aug 6, 2018

This doesn't actually fix the issue you linked. As in the issue the error is from placing a buy order and this pr addresses only canceling orders.

This fixes an error during cancelling orders which prevents fallback
cancel behavior when one-by-one cancel should be done.
@bitphage bitphage force-pushed the 246-unable-to-find-object branch from 3bef338 to d2641b1 Compare August 6, 2018 08:13
@bitphage
Copy link
Collaborator Author

bitphage commented Aug 6, 2018

You right, I updated the commit message.

@mikakoi mikakoi merged commit d2641b1 into Codaone:master Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants