Fix small bugs related to #487 #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're now creating table structure from migrations, this test needs to be adjusted.
This reverts commit 1386d02.
Use pkg_resources to access migrations files. When dexbot is packaged into egg file (normal `setup.py install` result), we cannot just access files inside egg (zip archive), so we're using native setuptools API to extract the files (resource_filename()). In case files are not in egg, pkg_resources will use normal file access. https://setuptools.readthedocs.io/en/latest/pkg_resources.html#basic-resource-access https://setuptools.readthedocs.io/en/latest/setuptools.html#accessing-data-files-at-runtime http://peak.telecommunity.com/DevCenter/PythonEggs#accessing-package-resources
joelvai
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now creating table structure from migrations, this test needs to
be adjusted.