ITP-JAN-25-LONDON| BAKYTBEK SYDYKOV | module-onboarding/Form controls| Week2 #214
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The previous ones were closed, here is a link to it: #167 (comment). |
Bahasyd
added
the
Complete
Form-Controls/index.html
Outdated
| </div> | ||
| <div> | ||
| <label for="e-mail">Email:</label> | ||
| <input type="e-mail" id="e-mail" name="user e-mail" required placeholder="Enter your e-mail"/> |
There was a problem hiding this comment.
There is no such input type as e-mail. Please, fix it.
There was a problem hiding this comment.
Name attribute (as well as any other attributes) can't have spaces inside. Please, fix it.
Form-Controls/index.html
Outdated
| <input type="e-mail" id="e-mail" name="user e-mail" required placeholder="Enter your e-mail"/> | ||
| </div> | ||
| <div> | ||
| <label for="color"> Please choose a color </label> <br> |
There was a problem hiding this comment.
I don't see any input with id color. I don't think you need this for attribute.
There was a problem hiding this comment.
Labels are usually used with inputs. If you don't have any corresponding input, I would suggest to replace <label> tag with something else.
Form-Controls/index.html
Outdated
| </div> | ||
| <div> | ||
| <label for="comment"> Comment: </label> | ||
| <input type="text" id="comment" name="comment"> |
There was a problem hiding this comment.
It is good that you have comment field. Usually comments are long texts. What can be a better tag for this type of input?
tyzia
added
Reviewed
|
Dear Mr. Andrei Navumau, can you check out this task, please? |
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.