Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITP-JAN-25- GLASGOW | AIDA ZHUKOVA | Module-Onboarding - Wireframe | WEEK 1 #223

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aidazhukova
Copy link

@aidazhukova aidazhukova commented Jan 29, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Brought the appearance of the website to the design that was declared in accordance with README file using css.

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 40d3751
🔍 Latest deploy log https://app.netlify.com/sites/cyf-onboarding-module/deploys/679a6eefd1d228000849782f
😎 Deploy Preview https://deploy-preview-223--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@shieldo shieldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this, @aidazhukova ! I can see that you've copied the lorem ipsum text for the different articles - that's fine except that the acceptance criteria does say that the articles need to be unique. (Maybe we can consider them unique if the titles are different, which they are?)

The Lighthouse check is 100% and criteria pass, and you've even added some CSS to style the footer some more. Good work!

@shieldo shieldo added the Reviewed Volunteer to add when completing a review label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants