Westmidlands/Millena Mesfin/Module-onboarding/Week#2

[Millena28]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	0fd37ee
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-onboarding-module/deploys/679d7c756eb69b000868f4a4
😎 Deploy Preview	https://deploy-preview-226--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[maceteligolden]

Fantastic work, you did a great job. i like how organized and consistent your code is, you also did a great executing task 1, 2, 3, and 4. However i have some things i would like to bring to your attention:

• i observed the semantic tags from the original html file provided with the questions ( i.e header and footer ) were removed in your work, is there a reason for that ?
• Although the testable criteria stated that the use of JS and CSS was prohibited, can you use only html tags to organize your form vertically instead of horizontally ?
• I like the idea of using "small" tags to display error messages. Since JS and CSS aren't allowed for this task, i don't think this is the right direction to go. i believe there is an attribute that will be more appropriate, can you add that to your input field instead ?
• Finally, i noticed you added a new requirement by adding the delivery date to the form. is this wasn't part of the requirement is there a reason for this ?

[Millena28]

Thank you @maceteligolden it was really help full comment really appreciate for your time.