ITP Jan25 | KATARZYNA KAZIMIERCZUK | Onboarding | WEEK 3 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shieldo
reviewed
Feb 1, 2025
There was a problem hiding this comment.
This is generally fine - if you perform a Lighthouse accessibility audit, though, it gets a score of 91. Please try doing the audit, reading what it says, and use maybe HTML or CSS to make the form pass the audit and get a 100 score (it should only need one change!)
|
|
||
| <div> | ||
| <label for="name">Name</label> | ||
| <input type="text" name="name" id="name" placeholder="Enter your name?" required> |
There was a problem hiding this comment.
There's a required attribute here, which works really well for ensuring that a user has entered something here. What should be consider as being a name, though? Can we add another requirement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I created a form with the required fields and ensured accessibility was at 100%.
Questions
No questions.