Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITP, JAN25, LONDON | YORSALEM MESMER |Model Onboarding Form_Control | WEEK 2 #235

Closed

Conversation

Jerry-yorsalem
Copy link

@Jerry-yorsalem Jerry-yorsalem commented Feb 1, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Feb 1, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit fe30fc5
🔍 Latest deploy log https://app.netlify.com/sites/cyf-onboarding-module/deploys/679e4de66d424b000816902c
😎 Deploy Preview https://deploy-preview-235--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jerry-yorsalem Jerry-yorsalem changed the title ITP, JAN25, LONDON | YORSALEM MESMER | Onboarding Form | WEEK 2 ITP, JAN25, LONDON | YORSALEM MESMER | Onboarding Form_Control | WEEK 2 Feb 1, 2025
@Jerry-yorsalem Jerry-yorsalem added the Needs Review Participant to add when requesting review label Feb 1, 2025
@Jerry-yorsalem Jerry-yorsalem changed the title ITP, JAN25, LONDON | YORSALEM MESMER | Onboarding Form_Control | WEEK 2 ITP, JAN25, LONDON | YORSALEM MESMER |Model Onboarding Form_Control | WEEK 2 Feb 1, 2025
@halilibrahimcelik halilibrahimcelik added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Feb 3, 2025
Copy link

@halilibrahimcelik halilibrahimcelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, you fulfilled all the requirements. It is always good to challenge yourself while learning new things. It would be better to add reset button to clear all fields in the form, you can learn more about form elements by looking at input types
https://www.w3schools.com/html/html_form_input_types.asp

@halilibrahimcelik halilibrahimcelik added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 3, 2025
@halilibrahimcelik
Copy link

you can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants