Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add old package name to "replace" in composer.json #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

koehnlein
Copy link

In c5b02cd the composer package was renamed from "codeception/visualception" into "codeception/module-visualception".

This pull requests adds the old name to "replace" section in composer.json. With this change, composer knows that the new package "codeception/module-visualception" (new) must not be installed together with "codeception/visualception" (old)

@ggiak
Copy link

ggiak commented May 25, 2023

Hey @koehnlein, good idea,
however the new version requires codeception 5 while the old one requires-dev codeception: 2.5.6

@koehnlein
Copy link
Author

@ggiak Interesting. I thought, the renaming would only happend after the release of 5.0.0 - but you are right, the renaming already was part of the 5.0.0 tag here on GitHub.

But then I wondered, why I have installed codeception/visualception:^5.0 in my projects and I think, I found the problem: The package is still published on packagist with its old name: https://packagist.org/packages/codeception/visualception it does not exist at all with its new name https://packagist.org/search/?query=codeception%2Fmodule-visualception

So the first step to fix this confusing situation, I would suggest to stop the GitHub/packagist sync to the old package "codeception/visualception".
After that, it would be great to have this PR merged, have a new release 5.0.1 or 5.1.0 or something and also have a new GitHub/packagist sync to the correct updated package name.
As last step I would suggest to add an "abandoned": "codeception/module-visualception" information into the old packagist package. You can do that on the packagist website, if you have the correct permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants