test: add initial ios integration tests #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokerttu
force-pushed
the
feat/google_maps_flutter_ground_overlay_support_ios_tests
branch
from
9a513bc to
4745a71
Compare
illuminati1911
force-pushed
the
feat/google_maps_flutter_ground_overlay_support_ios_tests
branch
from
5582bcc to
4555328
Compare
illuminati1911
changed the title
jokerttu
requested changes
Jan 9, 2025
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| import 'dart:async'; | |||
| import 'dart:convert'; | |||
| import 'dart:developer'; | |||
There was a problem hiding this comment.
Nope. Removed.
| expect(response.zIndex, source.zIndex); | ||
|
|
||
| // Only iOS supports zoomLevel | ||
| if (Platform.isIOS) { |
There was a problem hiding this comment.
unnecessary test.
these tests are always runend under ios
There was a problem hiding this comment.
Removed and also removed from Android.
| expect(response.zoomLevel, source.zoomLevel); | ||
| } | ||
| // Only Android (using position) and iOS supports `anchor` | ||
| if ((Platform.isAndroid && source.position != null) || Platform.isIOS) { |
There was a problem hiding this comment.
Removed and also removed from Android.
| @@ -3,7 +3,7 @@ | |||
| archiveVersion = 1; | |||
| classes = { | |||
| }; | |||
| objectVersion = 60; | |||
| objectVersion = 54; | |||
There was a problem hiding this comment.
what causes this. could this change be removed
There was a problem hiding this comment.
This is generated by Xcode based on the xcode version. It tells the project the format version of the project files. Which Xcode are you using? I'm not completely sure if it's safe to change it. We could try.
There was a problem hiding this comment.
Restored to 60.
...ogle_maps_flutter_ios/example/ios14/ios/RunnerTests/GoogleMapsGroundOverlayControllerTests.m
Outdated
Show resolved
Hide resolved
| @@ -41,4 +51,7 @@ | |||
|
|
|||
| /// Returns true if a ground overlay with the given identifier exists on the map. | |||
| - (bool)hasGroundOverlaysWithIdentifier:(NSString *)identifier; | |||
|
|
|||
| /// Returns FGMPlatformGroundOverlay for id. | |||
| (GroundOverlay groundOverlay) => | ||
| groundOverlay.position == null || | ||
| groundOverlay.zoomLevel != null), | ||
| 'On ios zoom level must be set when position is set for ground overlays.'); |
| assert( | ||
| mapObjects.groundOverlays.every((GroundOverlay groundOverlay) => | ||
| groundOverlay.position == null || groundOverlay.zoomLevel != null), | ||
| 'On ios zoom level must be set when position is set for ground overlays.'); |
jokerttu
merged commit 316f241
into
feat/google_maps_flutter_ground_overlay_support
1 check passed
jokerttu
deleted the
feat/google_maps_flutter_ground_overlay_support_ios_tests
branch
jokerttu
added a commit
that referenced
this pull request
Jan 9, 2025
* test: add initial ios integration tests * fix integration tests for iOS * fix: add zoom level assert to ios groundoverlays * test: ios ground overlay unit tests * test: refactor integration tests * refactor: pr fixes and refactoring --------- Co-authored-by: Joonas Kerttula <[email protected]>
jokerttu
added a commit
that referenced
this pull request
Jan 14, 2025
* test: add initial ios integration tests * fix integration tests for iOS * fix: add zoom level assert to ios groundoverlays * test: ios ground overlay unit tests * test: refactor integration tests * refactor: pr fixes and refactoring --------- Co-authored-by: Joonas Kerttula <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ground overlay iOS unit and integration tests + assert checks.