Feat: 북마크한 게시글 목록 조회 API #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
72
to
90
| List<Post> postList = queryFactory | ||
| .select(post) | ||
| .distinct() | ||
| .from(post) | ||
| .leftJoin(post.bookmarkList, bookmark).fetchJoin() | ||
| .where(bookmark.member.memberId.eq(member.getMemberId()) | ||
| .and(post.deletedAt.isNull())) | ||
| .offset(pageable.getOffset()) | ||
| .limit(pageable.getPageSize()) | ||
| .orderBy(bookmark.createdAt.desc(), bookmark.id.desc()) | ||
| .fetch(); | ||
|
|
||
| Long total = queryFactory | ||
| .select(post.count()) | ||
| .from(post) | ||
| .leftJoin(post.bookmarkList, bookmark) | ||
| .where(bookmark.member.memberId.eq(member.getMemberId()) | ||
| .and(post.deletedAt.isNull())) | ||
| .fetchOne(); |
There was a problem hiding this comment.
구한 post들을 반환할 때는 distinct를 사용하는데, total 개수 구할 때는 사용하지 않아서 값에 차이가 생기지는 않나요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
🔎코드 설명 및 참고 사항
💬리뷰 요구사항