Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No special case for 2-tuple humanize_list #2906

Closed
Zephyrkul opened this issue Jul 28, 2019 · 1 comment · Fixed by #2982
Closed

No special case for 2-tuple humanize_list #2906

Zephyrkul opened this issue Jul 28, 2019 · 1 comment · Fixed by #2982
Labels
Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.

Comments

@Zephyrkul
Copy link
Contributor

Other bugs

What were you trying to do?

use humanize_list with a 2-item list

What were you expecting to happen?

returns "x and y"

What actually happened?

returns "x, and y"
note the comma here

How can we reproduce this issue?

use humanize_list on a 2-tuple
@Zephyrkul Zephyrkul changed the title no special case for 2-tuple humanize_list No special case for 2-tuple humanize_list Jul 28, 2019
@mikeshardmind
Copy link
Contributor

This should likely use http://babel.pocoo.org/en/latest/api/lists.html#babel.lists.format_list as we transition to using babel for some i18n things.

@Flame442 Flame442 added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Aug 9, 2019
@Drapersniper Drapersniper mentioned this issue Sep 5, 2019
Merged
3 tasks
@mikeshardmind mikeshardmind added the Status: In Progress There's a PR open to deal with this, or an org member is working on this internally label Oct 2, 2019
@Jackenmen Jackenmen added Category: Bot Core Status: Accepted We want this Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` Status: In Progress There's a PR open to deal with this, or an org member is working on this internally and removed Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Category: Bot Core Status: Accepted We want this labels Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make humanize_list() use babel.
4 participants
@Jackenmen @mikeshardmind @Zephyrkul @Flame442