Make humanize_list() use babel.
#2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`[p]bankset maxbal` can be used to set the maximum bank balance Signed-off-by: Guy <[email protected]>
Signed-off-by: guyre <[email protected]>
Signed-off-by: guyre <[email protected]>
Signed-off-by: guyre <[email protected]>
…babel_locale` function to get a valid locale based on bot locale. Signed-off-by: guyre <[email protected]>
…babel_locale` function to get a valid locale based on bot locale. Signed-off-by: guyre <[email protected]>
Signed-off-by: guyre <[email protected]>
Flame442
added
the
Type: Enhancement
mikeshardmind
suggested changes
Sep 28, 2019
Drapersniper
added
the
Category: Core - API - Utils Package
Jackenmen
requested changes
Feb 23, 2020
There was a problem hiding this comment.
Docstring should contain some info about the style arg - what determines if locale supports specified style? Since it's not handled by Red, saying this is based on Babel's format_list should probably be enough unless you think it's worth saying more.
There is one other issue I see with this though - this will change the current behavior for the empty sequences and someone relying on this raising IndexError is gonna be surprised. I'm not sure if we want to pursue this breaking change in 3.4.0, but if we don't then you could add an if not items and raise IndexError there.
|
Whoever wants to pick this one up feel free to |
…babel_locale` function to get a valid locale based on bot locale. Signed-off-by: guyre <[email protected]>
Signed-off-by: guyre <[email protected]>
…ordBot into babel-list � Conflicts: � redbot/core/utils/chat_formatting.py
Drapersniper
added
the
QA: Passed
Jackenmen
approved these changes
Jul 9, 2020
Cog-CreatorsBot
added
the
Changelog Entry: Pending
Jackenmen
added
Changelog Entry: Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
humanize_listwill now usebabel.list.format_listfor it's logic. This closes #2906