-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create cog disabling API #4043
Create cog disabling API #4043
Conversation
This should be ready to go now, though I won't be able to test the changes personally on this one until slightly later (can update this when that's happened unless others are interested in confirming this before I do) |
Tested, updated, tested again and working as intended. |
Updated for settable default state per discord discussion. Current state of PR is untested. |
Rebased over the other changes to announcer made in #4089 , + uses the correct cog name |
Reiterating something from before: anything after the initial commit has not been personally tested by me yet. The initial commit (with message |
- Mostly for interop with with ctx.guild
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Streams cog should check if cog has been disabled in the guild it's checking stream alerts for.
- (I am not entirely sure about this, but it's probably the right thing to do) Tempban expiration shouldn't happen for guilds that disabled the Mod cog.
- I want @Drapersniper or @aikaterna to sign off on how this is used in Audio (I haven't checked that myself at all)
Everything else is in review comments.
Co-authored-by: jack1142 <[email protected]>
… value, it's not a large issue
1 & 2 are handled, as are the review comments. As far as I could tell, everything in audio should be initiated by a command, the events won't be triggered without a corresponding command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the review of Audio parts, there's only one review comment left.
just a quick FYI, there's a few events missing the check, Ill rewier it properly later today and note them down then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Just added 2 small code suggestion for strings that you can just merge
Co-authored-by: jack1142 <[email protected]>
Type
Description of the changes
Allow disabling cogs on a per guild basis (resolves #3945)