Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message edge case in parse_timedelta #6357

Merged
merged 3 commits into from
Apr 20, 2024
Merged

Fix error message edge case in parse_timedelta #6357

merged 3 commits into from
Apr 20, 2024

Conversation

Jackenmen
Copy link
Member

@Jackenmen Jackenmen commented Apr 20, 2024 •
edited
Loading

Description of the changes

Fixes error message for an edge case minimum and maximum values in the TimedeltaConverter.

Have the changes in this PR been tested?

Yes

@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Apr 20, 2024
@Jackenmen Jackenmen added this to the 3.5.9 milestone Apr 20, 2024
@github-actions github-actions bot added the Category: Core - API - Commands Package This is related to the `redbot.core.commands` package or `redbot.core.checks` module. label Apr 20, 2024
TrustyJAID
TrustyJAID approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@TrustyJAID TrustyJAID left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Jackenmen Jackenmen merged commit 47d4675 into Cog-Creators:V3/develop Apr 20, 2024
17 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Apr 20, 2024
@Jackenmen Jackenmen deleted the fix_error_msg_edge_case_in_timedeltaconverter branch April 20, 2024 22:27
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Apr 21, 2024
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
@Jackenmen @Dav-Git
Fix error message edge case in parse_timedelta (Cog-Creators#6357)
afa7967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrustyJAID TrustyJAID TrustyJAID approved these changes

Assignees
No one assigned
Labels
Category: Core - API - Commands Package This is related to the `redbot.core.commands` package or `redbot.core.checks` module. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.5.9
Development

Successfully merging this pull request may close these issues.
2 participants
@Jackenmen @TrustyJAID