Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerabilities socket-client deps - v2 #432

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

fabclj
Copy link
Collaborator

@fabclj fabclj commented Jun 25, 2024

Relocking @cognigy/socket-client dependencies

work item 70336

snyk issue:
https://security.snyk.io/vuln/SNYK-JS-WS-7266574

@fabclj fabclj requested a review from kwinto June 25, 2024 15:43
@fabclj fabclj changed the title Fix vulnerabilities v2 Fix vulnerabilities socket-client deps - v2 Jun 25, 2024
@fabclj fabclj requested a review from sushmi21 June 25, 2024 15:48
Copy link
Contributor

@kwinto kwinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the tests is failing but runs fine on master locally. Can you please check?

@fabclj
Copy link
Collaborator Author

fabclj commented Jun 26, 2024

One of the tests is failing but runs fine on master locally. Can you please check?

Running again it succeed. Just a flaky test about gallery, sometimes it fails.

@fabclj fabclj requested a review from kwinto June 26, 2024 08:44
@fabclj fabclj merged commit fbe918b into master Jun 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants