Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat Options: TTS #435

Merged
merged 13 commits into from
Jul 5, 2024
Merged

Chat Options: TTS #435

merged 13 commits into from
Jul 5, 2024

Conversation

kwinto
Copy link
Contributor

@kwinto kwinto commented Jul 2, 2024

This PR adds back TTS support to the V3. Also introduces relevant UI to the options screen.

We also try here to solve the ambiguity of having 2 settings for TTS activation:
settings.behavior?.enableTTS and settings.chatOptions.activateTTSToggle.

Besides that, we remove some dead code / build targets.

Success criteria:

  • User can enable/disable TTS in Options.
  • Messages are being read out when both mentioned above settings are active (or the user sets the TTS option active from the options screen manually)

Deploy this AI branch for testing:
https://cognigy.visualstudio.com/Cognigy.AI/_git/cognigy/pullrequest/31024

@kwinto kwinto requested a review from sushmi21 July 2, 2024 10:42
@sushmi21
Copy link
Collaborator

sushmi21 commented Jul 3, 2024

When TTS toggle is hidden, I see 2 section dividers in Chat options screen.
Screenshot from 2024-07-03 14-55-20

@sushmi21
Copy link
Collaborator

sushmi21 commented Jul 3, 2024

What is the difference between enableTTS and activateTTSToggle setting? Setting true in one and false in the other seems contradicting. We should then at least add additional description in the embedding file and also in (Cognigy.AI) Endpoint editor field tooltips.

@sushmi21
Copy link
Collaborator

sushmi21 commented Jul 3, 2024

When I enabled only enableTTS, incoming message was read out loud. Happened only once for me. Later none of the messages were read out, even if I set both settings to true.

@kwinto
Copy link
Contributor Author

kwinto commented Jul 4, 2024

What is the difference between enableTTS and activateTTSToggle setting? Setting true in one and false in the other seems contradicting. We should then at least add additional description in the embedding file and also in (Cognigy.AI) Endpoint editor field tooltips.

The requirements to enable TTS are currently ambiguous. I have added additional info to the docs.

@kwinto kwinto merged commit 8677c7b into v3 Jul 5, 2024
2 of 3 checks passed
@kwinto kwinto deleted the feature/59044-tts-options branch July 5, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants