fix: #65312 using regxp from v2 for url matching in text messages #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
The new regex is not recognizing the complete URL with query params |
You can check the message above under 'Text messages' tab of the demo page. |
Ah I see , let me check . Is there any guide on the allowed patterns on URLs in cognigy docs or are we supposed to handle all possible scenarios ? |
No, we do not have any documentation. We should handle all scenarios. |
vj-venkatesan
force-pushed
the
fix/#65312-broken-links-with-umlauts
branch
from
f914e77 to
c52866f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
url matcherRegular expression was not fulfilling links with characters such as umlauts. The same behavior is handled correctly in V2.This PR replaces the current regx with the regx used in V2.
This PR also adds a test case to cover this use case