Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove yarn.lock #1035

Closed
2 tasks done
rathorevaibhav opened this issue Sep 25, 2021 · 1 comment · Fixed by #1049
Closed
2 tasks done

Remove yarn.lock #1035

rathorevaibhav opened this issue Sep 25, 2021 · 1 comment · Fixed by #1049
Assignees
@rathorevaibhav
Labels
Points: 1 Good for beginners. Tasks that require not more than 4 hours to finish. status : ready to test Items that are ready for testing
Milestone
Sep 25 - Oct 01, ...

Comments

@rathorevaibhav
Copy link
Member

rathorevaibhav commented Sep 25, 2021 •
edited by vipulgoyal006
Loading

Describe the task
We are using npm to install our node dependencies. Yarn is an alternative for it which we're not using at all. However, there is a yarn.lock file that seems to give an impression that we're using Yarn. Also, because of yarn, the dependabot is showing a lot of security issues that are not our concern.
image

Expected behavior

  • Remove yarn.lock
  • Make sure there are no side-effects in installation and normal development commands due to file deletion
@rathorevaibhav rathorevaibhav added the Points: 1 Good for beginners. Tasks that require not more than 4 hours to finish. label Sep 25, 2021
@rathorevaibhav rathorevaibhav added this to the Sep 25 - Oct 01, 2021 milestone Sep 25, 2021
@vipulgoyal006 vipulgoyal006 self-assigned this Sep 30, 2021
@vipulgoyal006 vipulgoyal006 linked a pull request Sep 30, 2021 that will close this issue
Yarn.lock removed succesfully #1049
Merged
@P4NK4J P4NK4J mentioned this issue Sep 30, 2021
Merged
GauravGusain98 added a commit that referenced this issue Sep 30, 2021
@GauravGusain98
Merge pull request #1049 from ColoredCow/feature/#1035/Yarn_Removal
3351296 
Yarn.lock removed succesfully
@vipulgoyal006 vipulgoyal006 reopened this Oct 1, 2021
@vipulgoyal006 vipulgoyal006 added the status : ready to test Items that are ready for testing label Oct 1, 2021
@rathorevaibhav
Copy link
Member Author

This looks good. Closing. Thanks @vipulgoyal006 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rathorevaibhav rathorevaibhav

Labels
Points: 1 Good for beginners. Tasks that require not more than 4 hours to finish. status : ready to test Items that are ready for testing
Projects
None yet
Milestone
Sep 25 - Oct 01, 2021
Development

Successfully merging a pull request may close this issue.

Yarn.lock removed succesfully ColoredCow/portal
2 participants
@rathorevaibhav @vipulgoyal006