Skip to content
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.

ci: make CD and CI compatible #410

Merged
merged 3 commits into from
Dec 15, 2020
Merged

Conversation

spflueger
Copy link
Member

@spflueger spflueger commented Dec 15, 2020

Closes #411

Remove all tests from the CD workflow as the CI workflows already ensure that everything is running.

Remove all tests from the CD workflow as the CI workflows already ensure
that everything is running.
@spflueger spflueger added the 🖱️ DX Improvements to the Developer Experience label Dec 15, 2020
@spflueger spflueger requested a review from redeboer December 15, 2020 13:37
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #410 (6511fa7) into master (80d3451) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files          26       26           
  Lines        3750     3750           
  Branches      925      925           
=======================================
  Hits         3384     3384           
  Misses        184      184           
  Partials      182      182           
Flag Coverage Δ
unittests 90.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@spflueger spflueger changed the title cd: make CD and CI compatible ci: make CD and CI compatible Dec 15, 2020
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We should reconsider epic #19, either close it or tackle the remaining sub-issues.

@spflueger spflueger merged commit 0c3d938 into ComPWA:master Dec 15, 2020
@spflueger spflueger deleted the cd-ci-compat branch December 15, 2020 14:21
spflueger added a commit that referenced this pull request Dec 15, 2020
Remove all tests from the CD workflow as the CI workflows already ensure
that everything is running.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🖱️ DX Improvements to the Developer Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge CI and CD workflows
2 participants