Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove StateTransitionCollection #155

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Feb 21, 2022

Removed the ReactionInfo.transition_groups attribute and its corresponding StateTransitionCollection. Groupings can now be obtained with ReactionInfo.group_by_topology().

Motivation:

  • Reduces the size and complexity of the transition module.
  • Makes it easier to construct new ReactionInfo object from an iterable of StateTransitions (no need to group them yourself first).

@redeboer redeboer added the ⚠️ Interface Breaking changes to the API label Feb 21, 2022
@redeboer redeboer self-assigned this Feb 21, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer redeboer added this to the 0.10.0 milestone Feb 21, 2022
@redeboer redeboer merged commit c6c35de into ComPWA:main Feb 21, 2022
@redeboer redeboer deleted the remove-StateTransitionCollection branch February 21, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ Interface Breaking changes to the API
Projects
Status: Upcoming
Development

Successfully merging this pull request may close these issues.

1 participant