N°7137 - DataSynchro: Remove "Organization" as default value for SynchroReplica->dest_class

[Hipska]

It appears to be existing since commit f3f2eb5 and I never found this a logical value..
https://github.com/Combodo/iTop/blame/f3f2eb5c797ec40d331798e134b3cd73b5bfd4ea/synchro/synchrodatasource.class.inc.php#L1006

[piRGoif]

Hello,
The commit introducing the default value for SynchroReplica.dest_class is actually f3f2eb5, made back in 2011 (!!)
There are no explicit reason invoked in the commit message nor bug reference that could help :/

[Hipska]

Hmm, right. But there are also a lot in between that don't have this as default value..

[piRGoif]

I don't see that. Which commit(s) are you refering to ?

[Hipska]

So 2dfad12 was only 4 years ago and changed from not having a default value to having Organization. So the commits before that didn't have a default..

Nevermind, I just saw the commit before that did actually had this default as well, so you are right it is since f3f2eb5, updated the PR description.

[Molkobain]

Accepted during technical, it makes no sense to have this value and null value is allowed anyway.

[Molkobain]

Accepted during functional review. To be retrofitted in support/2.7.

[Molkobain]

@Hipska can you modify the PR (and the branch if necessary) to target support/2.7?

[Hipska]

Done

[Molkobain]

Thanks, I'll just wait for 2.7.10 to be released and I'll merge.

[Molkobain]

Did you test it @Hipska ?
It didn't even pass the setup.

[Hipska]

Oh, it should probably be 'default_value' => '', then?

Don't know anymore why I removed that line.

[Molkobain]

I know the fix, but I'm surprised you didn't test your branch.

[Hipska]

No, I don't have any 2.7 systems running anymore..

[Molkobain]

Fixed in 7a0a4e3