Allow resizing node from any corner #427
Draft
+196
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for looking at this! Just wanted to check if this was generated code or not - the reason I ask is it doesn't follow the pattern / style of the rest of the repo, so will require a decent bit of refactoring to merge. If you're not attached to the code in any way, I can probably do a quick rewrite of parts instead. |
|
I'm definitely not attached to it in any way. By all means feel free to make happen what needs to in order for this to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other than the top left and right corners causing a slight bump in size after initial cursor movement that should be investigated, this seems to work.
Not familiar with how to address and/or adjust the frontend tests currently.