Basecamp 3 provider #180
Merged
Basecamp 3 provider #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jawnnypoo
reviewed
Sep 10, 2021
| // return console.log(err) | ||
| // } | ||
| // }) | ||
| //let embed: Embed |
There was a problem hiding this comment.
Can you remove these commented out bits please?
Jawnnypoo
approved these changes
Sep 10, 2021
|
If you have the time, can you also add a test to this with some test JSON? |
|
I can do the follow ups actually, thanks a bunch! |
|
Thanks for the great tool! In fact, I have never code in TypeScript before, but your code is so well-structured and the library has such a good API that it was simple for me to write new provider :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
here is Basecamp 3 provider