Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Provider: Confluence #190

Merged
merged 2 commits into from
May 2, 2022
Merged

Conversation

SG004
Copy link
Contributor

@SG004 SG004 commented Dec 31, 2021

Initial Confluence Provider Implementation. I wanted this functionality for a project of mine, and so when I saw that the project was open source, I was ecstatic that I could help add functionality to your awesome software.

There are a few missing features, and I spent the better half of an evening working on this, let me know if this initial implementation is enough for an initial submission or if I need to add things.

@SG004 SG004 changed the title Preliminary Confluence Provider Implementation New Provider: Confluence Dec 31, 2021
Copy link
Collaborator

@dscalzi dscalzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please lint the project

@SG004
Copy link
Contributor Author

SG004 commented Jan 4, 2022

Please lint the project

I am unfamiliar with what you mean by lint. What do you mean lint?

@SG004
Copy link
Contributor Author

SG004 commented Jan 4, 2022

nvm googled it

@dscalzi
Copy link
Collaborator

dscalzi commented Jan 4, 2022

Run npm run lint and fix the style violations

@SG004
Copy link
Contributor Author

SG004 commented Jan 4, 2022

Ran npm run lint on the following scripts (There were no violations)

  • .\src\index.ts
  • .\src\provider\Confluence.ts
  • .\test\confluence\confluence-spec.ts

image

@SG004 SG004 requested a review from dscalzi April 26, 2022 13:10
@Jawnnypoo Jawnnypoo merged commit edb4400 into Commit451:main May 2, 2022
@Jawnnypoo
Copy link
Member

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants