Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CODEOWNERS #316

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Fix CODEOWNERS #316

merged 1 commit into from
Dec 8, 2024

Conversation

Alirexaa
Copy link
Member

@Alirexaa Alirexaa commented Dec 8, 2024

Code owners' roles end with an underscore. Only the directory and files that start with an underscore are assigned to the given person or team, not all files and subdirectories.

After this PR is merged the following code owner icon should appear on each owned file.

File in the main branch:

file in the main branch

File in the PR branch:

File in the PR branch

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@Alirexaa Alirexaa requested a review from aaronpowell December 8, 2024 07:02
Copy link
Member

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think the mistake has come from linting tools

@aaronpowell aaronpowell merged commit 0d121c7 into main Dec 8, 2024
4 checks passed
@aaronpowell aaronpowell deleted the Alirexaa-patch-1 branch December 8, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants