-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template Infrastructure #4
Comments
The template infrastructure will need to be able to add a reference to the new sample in the uber-sample uwp/wasm heads automatically when the project is created. |
@michael-hawker @Arlodotexe what do you think about merging in the template before we apply the uno changes? I think this might be a nice checkpoint to settle on the basic template contents and then layer then uno requirements on top. It's in a good working state, so I'm hoping the tests and template generation to continue to work after we apply the uno upgrade. |
@shweaver-MSFT part of that is in main already #11, can you see what conflicts you see if you rebase? The other PR #12 Arlo has open is about sample loading for us to handle multiple samples which is relatively isolated still. |
@michael-hawker, what part do you mean? Not the template... do you mean the extra uno requirements? I'm not expecting any conflicts, because all of my work is in the Template folder so far. I see some good structure from #11 in the CanvasLayout sample. But I'm hesitant to adopt any uno patterns until we've figured out the mechanism to support the uber sample, which #12 seems to be focused on. I can focus on getting the UI tests working from CI, while you guys handle the uber sample mechanism. Sound good? |
Yeah, sounds good @shweaver-MSFT! I'll take a look at the template PR in more depth and give it a spin locally. Will let you know if I run into any issues. Thanks! |
I went through the exercise of porting the UITest projects over from the main toolkit, and I'm not convinced it's the right thing to do. Just because it adds so much extra to the template. We go from one UI test project to four just for the sake of working in the CI. I fear it'll create a ton of duplicated boilerplate test code across the repo, and it's not as dev friendly. Perhaps we can work it into the uber sample somehow... |
ConsiderationsRandom bits discovered while fleshing out the sample system that should be taken into consideration for the template system. Project template.
Sample page template
|
Not true ;) |
A new PR for this is now at #76 as the solution structure and requirements have evolved since #9 was worked on. The biggest changes in the requirements for this are:
|
closed by #76 |
The newer packages have emsdk 3.1.12 builds, which are compatible with Uno.Wasm.Bootstrap 7.x. Fixes #4
Define the basic structure of a Labs Project and produce a template so it can be easily copied and distributed.
Labs project requirements
We expect the following of resources from Labs project contributions:
Guidance and tips
In addition to the baseline project structure, we also want to jump-start developers who use the template. The template should include additional resources such as:
Template generation
To distribute the template, use the
dotnet new
CLI and add the configuration to the repo.VSIX was a suggested alternative, but it doesn't support more than one project at a time. We need to be able to generate multiple projects at once.
Open questions
The text was updated successfully, but these errors were encountered: