-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for both WinUI 2 and 3 under Uno platform #75
Conversation
… Fixed compiling GTK under WinUI 2 / 3
…nUI 2 would cause compilation constant not being cleaned up
@michael-hawker We should resync on what we want the Build Validation pipelines to look like with these changes.
|
@Arlodotexe had put a break down in the issue here: #28 (comment) Let's add another job to the pipeline so that in one it'll build and validate on WinUI 2 and create the WinUI 2 based packages, and then in the other it'll do the WinUI 3. We'll need the Uno switch script to when in WinUI 2 mode to change the NuGet Package Identifier in the Experiments csproj to be |
So we'd effectively just copy the existing pipeline, but add in the WinUI 3 switch for Uno?
I'll do some tinkering and see about importing that part of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. How does this work for the UWP/WinAppSDK heads in the Experiment projects? Do they just still work by default?
Yep, this is just for Uno. Both WinAppSDK and UWP should continue to work whether Uno is using WinUI 2 or 3, both in the IDE and in the nupkg since they're under different TargetFrameworks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't get the experiment to run the WASM head in WinUI 3 mode, just was blank page after Uno logo. Worked fine in default WinUI 2 mode though (as did the UWP/WinAppSDK heads).
ah, just tried to change branches and got this: Would that be the difference with the other flag you mentioned @Arlodotexe? Doing a |
@@ -8,10 +8,11 @@ Param ( | |||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the PowerShell guidelines for naming convention be uppercase for like AllowGitChanges
so the flag is -AllowGitChanges
on the commandline?
@Arlodotexe mind turning the verbose on the uno check so we can get more details? Edit: nvm, realized I could do it. Just wanted more info as it looked green. |
Confirmed this is a transient issue due to a Google url with Uno Check. |
Arlo confirmed that the WASM WinUI things work in a separate app, so we'll commit this and then fix forward with tracking issue #77 as we default to the working WinUI 2 versions for now. |
…winui-2-and-3 Add support for both WinUI 2 and 3 under Uno platform
This PR introduces the ability to switch cross platform Uno heads and libraries between using WinUI 2 and 3.
Labs.Uno.props
file.