-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial setup of configuration files, build script, and documentation for the repo #1
Conversation
0d67409
to
fe18103
Compare
Hitting some weird issue with paths in Seems to be concatenating things together that shouldn't be like that. Can reproduce locally just by calling These calls seem to do the right thing locally? But when run in the script it's like it's finding the 'samples' directory as the root for the component instead of 'Converters'? So not sure why this is failing... FYI @Arlodotexe
|
@michael-hawker This will be fixed in CommunityToolkit/Tooling-Windows-Submodule#25 |
Current error from SG should be resolved once it gets fixed as part of CommunityToolkit/Tooling-Windows-Submodule#31 |
We've reverted the fix that would have allowed closing this off early by postponing WASM support, due to time constraints and delays caused by newly discovered bugs. Details are all here - CommunityToolkit/Tooling-Windows-Submodule#32 (comment) We need to close this off very soon as it's blocking us from porting other components. The above in mind, we'll add WASM back and support Uno proper for this first component. |
- Updated to `CommunityToolkit.WinUI.Converters` namespace - Changed `FormatStringConverter` to `IFormattableToStringConverter` to differentiate from `StringFormatConverter` (too confusing to have such a similar name) - Merged differences between UWP and WinAppSDK branches of main toolkit, _have proper updates from both_ - Imported original monolith doc from our doc repo as a starting point, converted one sample as a starting point for `StringFormatConverter` - Brought over existing unit tests from main repo (**did not** compare or merge with WinUI branch **nor** update to use our helpers), but passing for UWP and WASDK - Found platform gap for ColorToDisplayNameConverter, see microsoft/microsoft-ui-xaml#8287
99c962d
to
643bca8
Compare
Cleaned up the commits, rebased on the latest tooling, and compared against the latest Uno fork. Only differences for Uno are in the Color and Resource converters (basically similarly due to the changes there for Windows App SDK). Will see if we get a clean build and/or still hit the .NET Native issue or something I missed, though I don't see any Uno warnings locally. |
https://dev.azure.com/dotnet/CommunityToolkit/_artifacts/feed/CommunityToolkit-MainLatest (Updated to 8.0.0-beta.1 version schema for Converters package for now as test.)
23c42e5
to
4446701
Compare
Also starts #2 of bringing over Converters as we need a component to test CI without more work.
Was a good test-case in bringing stuff over. Took a couple of hours to bring these over with slight merging/updating and testing. Promising for sure, though a small subset of things.